Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): support aliyun oss #1157

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1157 (b2bc84e) into main (62a26b6) will decrease coverage by 9.42%.
The diff coverage is 24.35%.

@@             Coverage Diff              @@
##               main    #1157      +/-   ##
============================================
- Coverage     75.78%   66.35%   -9.43%     
- Complexity      853      883      +30     
============================================
  Files           203      142      -61     
  Lines         10774     3900    -6874     
  Branches        411      409       -2     
============================================
- Hits           8165     2588    -5577     
+ Misses         2459     1165    -1294     
+ Partials        150      147       -3     
Flag Coverage Δ
controller 66.35% <24.35%> (+1.38%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...le/mlops/domain/swds/objectstore/StorageAuths.java 84.00% <ø> (ø)
...ops/storage/aliyun/StorageAccessServiceAliyun.java 0.00% <0.00%> (ø)
...ops/storage/configuration/StorageAccessConfig.java 0.00% <0.00%> (ø)
.../ai/starwhale/mlops/storage/fs/FileStorageEnv.java 0.00% <0.00%> (ø)
...va/ai/starwhale/mlops/storage/util/MetaHelper.java 9.09% <9.09%> (ø)
...s/domain/swds/objectstore/StorageAccessParser.java 48.14% <10.00%> (-1.86%) ⬇️
...starwhale/mlops/storage/LengthAbleInputStream.java 33.33% <33.33%> (ø)
...ale/mlops/storage/fs/StorageAccessServiceFile.java 47.82% <33.33%> (-1.07%) ⬇️
...java/ai/starwhale/mlops/datastore/ObjectStore.java 73.33% <100.00%> (+6.66%) ⬆️
...whale/mlops/storage/s3/StorageAccessServiceS3.java 80.37% <100.00%> (+6.23%) ⬆️
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui marked this pull request as draft September 9, 2022 09:04
@jialeicui jialeicui force-pushed the ali-oss branch 2 times, most recently from 459037a to 79da602 Compare September 9, 2022 09:21
@jialeicui jialeicui marked this pull request as ready for review September 9, 2022 09:54
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants