Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): add test for JobMapper,JobSwdsVersionMapper,ProjectMapper #1235

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

anda-ren
Copy link
Member

Description

add test for JobMapper,JobSwdsVersionMapper,ProjectMapper

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added the chore 🛎️ some tiny change label Sep 16, 2022
@anda-ren anda-ren added this to the v0.3 milestone Sep 16, 2022
@anda-ren anda-ren added this to In progress in Starwhale Product via automation Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1235 (11cf917) into main (7b04d0e) will decrease coverage by 12.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1235       +/-   ##
=============================================
- Coverage     70.56%   58.52%   -12.04%     
- Complexity     1124     1125        +1     
=============================================
  Files           284      222       -62     
  Lines         13092     6132     -6960     
  Branches        637      639        +2     
=============================================
- Hits           9238     3589     -5649     
+ Misses         3657     2345     -1312     
- Partials        197      198        +1     
Flag Coverage Δ
controller 58.52% <100.00%> (-0.04%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/ai/starwhale/mlops/api/EvaluationController.java 100.00% <ø> (ø)
...ale/mlops/domain/evaluation/EvaluationService.java 76.11% <100.00%> (ø)
...n/java/ai/starwhale/mlops/datastore/DataStore.java 94.15% <0.00%> (-1.12%) ⬇️
...whale/mlops/storage/s3/StorageAccessServiceS3.java 79.61% <0.00%> (-0.77%) ⬇️
client/starwhale/core/dataset/model.py
client/starwhale/core/project/model.py
client/starwhale/core/dataset/store.py
client/starwhale/api/dataset.py
client/starwhale/core/job/model.py
client/starwhale/api/_impl/job.py
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Starwhale Product automation moved this from In progress to Reviewer approved Sep 19, 2022
@dreamlandliu dreamlandliu merged commit 52075f3 into star-whale:main Sep 19, 2022
Starwhale Product automation moved this from Reviewer approved to Done Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants