Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(sdk): export starwhale package functions, classes and consts directly #1269

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Sep 21, 2022

Description

Users can from starwhale import functions, classes, and consts directly which follows the popular package import style.

For the examples with starwhale SDK:

  • before:
    from starwhale.api.job import Context
    from starwhale.api.model import PipelineHandler
    from starwhale.api.dataset import Image
  • after:
    from starwhale import Image, Context, PipelineHandler
    

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Sep 21, 2022
@tianweidut tianweidut self-assigned this Sep 21, 2022
@tianweidut tianweidut added this to In progress in Starwhale Product via automation Sep 21, 2022
@tianweidut tianweidut changed the title enhance(sdk): export starwhale package functions, classes and consts enhance(sdk): export starwhale package functions, classes and consts directly Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@0502bb4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2010565 differs from pull request most recent head 6234a99. Consider uploading reports for the commit 6234a99 to get more accurate results

@@           Coverage Diff           @@
##             main    #1269   +/-   ##
=======================================
  Coverage        ?   73.88%           
  Complexity      ?     1212           
=======================================
  Files           ?      287           
  Lines           ?    13399           
  Branches        ?      651           
=======================================
  Hits            ?     9900           
  Misses          ?     3277           
  Partials        ?      222           
Flag Coverage Δ
controller 60.87% <0.00%> (?)
standalone 85.64% <0.00%> (?)
unittests 85.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

goldenxinxing
goldenxinxing previously approved these changes Sep 22, 2022
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starwhale Product automation moved this from In progress to Reviewer approved Sep 22, 2022
Starwhale Product automation moved this from Reviewer approved to Review in progress Sep 22, 2022
Starwhale Product automation moved this from Review in progress to Reviewer approved Sep 22, 2022
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 260ec29 into star-whale:main Sep 22, 2022
Starwhale Product automation moved this from Reviewer approved to Done Sep 22, 2022
@tianweidut tianweidut deleted the enhance/starwhale-package branch September 22, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants