Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datastore): remove wrapper project and eval_version useless env #1274

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Sep 21, 2022
@tianweidut tianweidut self-assigned this Sep 21, 2022
@tianweidut tianweidut added this to In progress in Starwhale Product via automation Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1274 (6f90e02) into main (1959fe5) will increase coverage by 11.75%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1274       +/-   ##
=============================================
+ Coverage     73.86%   85.62%   +11.75%     
=============================================
  Files           287       62      -225     
  Lines         13390     7027     -6363     
  Branches        651        0      -651     
=============================================
- Hits           9891     6017     -3874     
+ Misses         3277     1010     -2267     
+ Partials        222        0      -222     
Flag Coverage Δ
controller ?
standalone 85.62% <100.00%> (-0.01%) ⬇️
unittests 85.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/data_store.py 96.00% <100.00%> (+<0.01%) ⬆️
client/starwhale/api/_impl/wrapper.py 88.88% <100.00%> (-0.36%) ⬇️
...ain/java/ai/starwhale/mlops/storage/env/S3Env.java
.../starwhale/mlops/exception/SwProcessException.java
.../task/status/watchers/log/TaskLogK8sCollector.java
...ale/mlops/domain/project/ProjectRoleConvertor.java
...ai/starwhale/mlops/domain/job/cache/JobLoader.java
...a/ai/starwhale/mlops/api/protocol/dag/GraphVo.java
.../java/ai/starwhale/mlops/common/util/HttpUtil.java
.../starwhale/mlops/exception/StarwhaleException.java
... and 217 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starwhale Product automation moved this from In progress to Reviewer approved Sep 21, 2022
@tianweidut tianweidut merged commit 10a9204 into star-whale:main Sep 22, 2022
Starwhale Product automation moved this from Reviewer approved to Done Sep 22, 2022
@tianweidut tianweidut deleted the chore/remove-wrapper-env branch April 17, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants