Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): resource pool implementation change;update doc #1420

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

anda-ren
Copy link
Member

Description

resource pool implementation change;

Screenshot from 2022-10-25 11-34-37

update doc

resouce pool list api change

cc @waynelwz
http://renyanda-20221025.pre.intra.starwhale.ai/swagger-ui/index.html#/System/listResourcePools

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren self-assigned this Oct 25, 2022
@anda-ren anda-ren added the refactor 🐛 refactor code label Oct 25, 2022
@anda-ren anda-ren added this to the v0.3.1 milestone Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1420 (8dcd022) into main (53bf274) will decrease coverage by 6.03%.
The diff coverage is 68.75%.

@@             Coverage Diff              @@
##               main    #1420      +/-   ##
============================================
- Coverage     80.16%   74.13%   -6.04%     
+ Complexity     1538     1525      -13     
============================================
  Files           295      226      -69     
  Lines         14013     6553    -7460     
  Branches        697      689       -8     
============================================
- Hits          11234     4858    -6376     
+ Misses         2506     1427    -1079     
+ Partials        273      268       -5     
Flag Coverage Δ
controller 74.13% <68.75%> (+0.32%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/ai/starwhale/mlops/api/SystemController.java 100.00% <ø> (ø)
...a/ai/starwhale/mlops/api/protocol/task/TaskVo.java 0.00% <0.00%> (ø)
...i/starwhale/mlops/domain/system/SystemService.java 0.00% <0.00%> (ø)
...hale/mlops/schedule/k8s/ResourceOverwriteSpec.java 94.11% <ø> (ø)
...hale/mlops/domain/system/SystemSettingService.java 55.17% <16.66%> (-6.37%) ⬇️
...starwhale/mlops/schedule/k8s/K8sTaskScheduler.java 82.85% <66.66%> (-0.96%) ⬇️
...java/ai/starwhale/mlops/domain/job/JobService.java 84.00% <100.00%> (-0.22%) ⬇️
...ale/mlops/domain/job/converter/JobBoConverter.java 91.76% <100.00%> (-0.38%) ⬇️
...whale/mlops/domain/job/converter/JobConvertor.java 93.54% <100.00%> (-0.57%) ⬇️
.../mlops/domain/system/resourcepool/bo/Resource.java 100.00% <100.00%> (ø)
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 0ff8d96 into star-whale:main Oct 25, 2022
@anda-ren anda-ren linked an issue Oct 28, 2022 that may be closed by this pull request
@anda-ren anda-ren deleted the resource_pool branch December 2, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🐛 refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alter resource pool to system config
2 participants