-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use signed url instead of auth propagation #1422
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
============================================
- Coverage 80.35% 80.27% -0.09%
- Complexity 1525 1539 +14
============================================
Files 291 292 +1
Lines 13930 14035 +105
Branches 689 694 +5
============================================
+ Hits 11194 11266 +72
- Misses 2468 2496 +28
- Partials 268 273 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
server/controller/src/main/java/ai/starwhale/mlops/schedule/k8s/K8sTaskScheduler.java
Show resolved
Hide resolved
...orage-access-layer/src/main/java/ai/starwhale/mlops/storage/fs/StorageAccessServiceFile.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
merge to #1443 |
Description
Modules
Checklist