Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use signed url instead of auth propagation #1422

Closed
wants to merge 9 commits into from

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Oct 25, 2022

Description

  • use signed url instead of auth propagation in initContainers
  • use signed url instead of auth propagation in client dataset

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1422 (38faf6a) into main (0ff8d96) will decrease coverage by 0.08%.
The diff coverage is 74.02%.

❗ Current head 38faf6a differs from pull request most recent head 7563daf. Consider uploading reports for the commit 7563daf to get more accurate results

@@             Coverage Diff              @@
##               main    #1422      +/-   ##
============================================
- Coverage     80.35%   80.27%   -0.09%     
- Complexity     1525     1539      +14     
============================================
  Files           291      292       +1     
  Lines         13930    14035     +105     
  Branches        689      694       +5     
============================================
+ Hits          11194    11266      +72     
- Misses         2468     2496      +28     
- Partials        268      273       +5     
Flag Coverage Δ
controller 74.06% <65.48%> (-0.08%) ⬇️
standalone 85.84% <97.56%> (-0.05%) ⬇️
unittests 85.84% <97.56%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../starwhale/mlops/domain/swds/SwDatasetService.java 86.29% <0.00%> (-0.71%) ⬇️
...s/domain/swds/objectstore/StorageAccessParser.java 75.00% <0.00%> (-2.78%) ⬇️
...tarwhale/mlops/storage/env/UserStorageAuthEnv.java 0.00% <ø> (ø)
...mlops/storage/minio/StorageAccessServiceMinio.java 33.87% <25.00%> (-0.96%) ⬇️
...le/mlops/domain/swds/objectstore/DsFileGetter.java 59.37% <50.00%> (-1.50%) ⬇️
...starwhale/mlops/schedule/k8s/K8sTaskScheduler.java 74.57% <57.14%> (-8.29%) ⬇️
...ale/mlops/storage/fs/StorageAccessServiceFile.java 56.86% <77.77%> (+9.03%) ⬆️
.../ai/starwhale/mlops/api/ObjectStoreController.java 82.75% <82.75%> (ø)
...whale/mlops/storage/s3/StorageAccessServiceS3.java 80.00% <90.00%> (+0.90%) ⬆️
client/starwhale/core/dataset/store.py 86.12% <96.77%> (-1.34%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anda-ren anda-ren self-assigned this Oct 28, 2022
@anda-ren anda-ren added the refactor 🐛 refactor code label Oct 28, 2022
@anda-ren anda-ren marked this pull request as ready for review October 28, 2022 02:21
@anda-ren anda-ren changed the title wip:feat: use signed url instead of auth propagation feat: use signed url instead of auth propagation Oct 28, 2022
@anda-ren anda-ren linked an issue Oct 28, 2022 that may be closed by this pull request
@jialeicui jialeicui self-requested a review October 31, 2022 11:26
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren
Copy link
Member Author

anda-ren commented Nov 1, 2022

merge to #1443

@anda-ren anda-ren closed this Nov 1, 2022
@anda-ren anda-ren linked an issue Nov 1, 2022 that may be closed by this pull request
@anda-ren anda-ren deleted the sign_url branch December 2, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🐛 refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants