Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(SDK): fix loader consumption missing upload issue #2849

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working sdk 🐶 e2e labels Oct 11, 2023
@tianweidut tianweidut self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2849 (e91c2e6) into main (d0efb3b) will increase coverage by 8.90%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2849      +/-   ##
============================================
+ Coverage     83.64%   92.55%   +8.90%     
============================================
  Files           538      122     -416     
  Lines         29371    15088   -14283     
  Branches       1634        0    -1634     
============================================
- Hits          24567    13964   -10603     
+ Misses         4045     1124    -2921     
+ Partials        759        0     -759     
Flag Coverage Δ
controller ?
standalone 92.55% <100.00%> (+0.04%) ⬆️
unittests 92.55% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/api/_impl/dataset/loader.py 99.09% <100.00%> (+<0.01%) ⬆️

... and 417 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit adec9d2 into star-whale:main Oct 12, 2023
37 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working e2e sdk 🐶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants