Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support on_schema_change for incremental models #134

Closed
wants to merge 2 commits into from
Closed

Support on_schema_change for incremental models #134

wants to merge 2 commits into from

Conversation

mdesmet
Copy link
Member

@mdesmet mdesmet commented Sep 22, 2022

Overview

resolves #48

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • README.md updated and added information about my change
  • I have run changie new to create a changelog entry

)
}}

{% set string_type = 'string' if target.type == 'bigquery' else 'varchar(10)' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace/remove bigquery here and other places in fixtures.py.

@mdesmet
Copy link
Member Author

mdesmet commented Sep 23, 2022

Closing in favour of #136

@mdesmet mdesmet closed this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental loads don't work where schema is different. Implement on_schema_change
2 participants