Multiple tweaks #139
Multiple tweaks #139
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
hovaesco
force-pushed
the
hovaesco/multiple-tweaks
branch
from
4fc42d0
to
3fa8552
Compare
.github/workflows/ci.yml
Outdated
| exclude: | ||
| - engine: "starburst_galaxy" | ||
| python: "3.9" | ||
| isForkBranch: true | ||
| isMaster: false |
There was a problem hiding this comment.
Why isMaster? Sometimes rebase can cause some changes to only occur once merged with latest master.
There was a problem hiding this comment.
Currently, Galaxy tests are not running on master.
There was a problem hiding this comment.
It would still trigger on isForkBranch true and isMaster true.
I think just using one condition seems simpler. Note that I changed into isStarburstBranch.
(github.event_name == 'pull_request' && contains(github.event.pull_request.head.repo.full_name, 'starburstdata')) || github.event_name != 'pull_request'
3fa8552
to
2518000
Compare
hovaesco
force-pushed
the
hovaesco/multiple-tweaks
branch
2 times, most recently
from
7e74784
to
4cef134
Compare
docker/init_trino.bash
Outdated
| docker-compose -f docker-compose-trino.yml up -d | ||
| docker-compose -f docker/util.yml run --rm util wait_for_up trino 8080 | ||
| while ! docker-compose -f docker-compose-trino.yml logs trino 2>&1 | tail -n 1 | grep "SERVER STARTED"; do sleep 2; done |
There was a problem hiding this comment.
Why did you opt to not have timeout option anymore?
| -Xmx1G | ||
| -XX:-UseBiasedLocking | ||
| -XX:+UseG1GC | ||
| -XX:InitialRAMPercentage=80 |
There was a problem hiding this comment.
Probably this should go into a commit of its own to have corresponding comments.
There was a problem hiding this comment.
extracted to the separate commit
hovaesco
force-pushed
the
hovaesco/multiple-tweaks
branch
from
4cef134
to
4df0319
Compare
|
Side aspect from running against Starburst Galaxy: https://github.com/starburstdata/dbt-trino/actions/runs/3174859319/jobs/5172178878 |
hovaesco
force-pushed
the
hovaesco/multiple-tweaks
branch
from
4df0319
to
40a6dd5
Compare
Overview
Resolves #133
Update docker testing images and scripts commit is to overcome flaky tests issues.
Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry