Bumping version to 1.5.0rc2, Add model contracts

.changes/unreleased/Features-20230419-115208.yaml

@@ -0,0 +1,7 @@
+kind: Features
+body: Add model contracts
+time: 2023-04-19T11:52:08.343309+02:00
+custom:
+  Author: damian3031
+  Issue: "284"
+  PR: "286"

dbt/adapters/trino/__version__.py

@@ -1 +1 @@
-version = "1.4.2"
+version = "1.5.0rc2"

dbt/adapters/trino/connections.py

@@ -508,3 +508,7 @@ def execute(self, sql, auto_begin=False, fetch=False):
         status = self.get_response(cursor)
         table = self.get_result_from_cursor(cursor)
         return status, table
+
+    @classmethod
+    def data_type_code_to_name(cls, type_code) -> str:
+        return type_code.split("(")[0].upper()

dbt/adapters/trino/impl.py

@@ -2,8 +2,9 @@
 from typing import Dict, Optional
 
 import agate
-from dbt.adapters.base.impl import AdapterConfig
+from dbt.adapters.base.impl import AdapterConfig, ConstraintSupport
 from dbt.adapters.sql import SQLAdapter
+from dbt.contracts.graph.nodes import ConstraintType
 from dbt.exceptions import DbtDatabaseError
 
 from dbt.adapters.trino import TrinoColumn, TrinoConnectionManager, TrinoRelation
@@ -21,6 +22,14 @@ class TrinoAdapter(SQLAdapter):
     ConnectionManager = TrinoConnectionManager
     AdapterSpecificConfigs = TrinoConfig
 
+    CONSTRAINT_SUPPORT = {
+        ConstraintType.check: ConstraintSupport.NOT_SUPPORTED,
+        ConstraintType.not_null: ConstraintSupport.NOT_SUPPORTED,
+        ConstraintType.unique: ConstraintSupport.NOT_SUPPORTED,
+        ConstraintType.primary_key: ConstraintSupport.NOT_SUPPORTED,
+        ConstraintType.foreign_key: ConstraintSupport.NOT_SUPPORTED,
+    }
+
     @classmethod
     def date_function(cls):
         return "datenow()"

dbt/include/trino/macros/adapters.sql

@@ -91,11 +91,33 @@
 
 {% macro trino__create_table_as(temporary, relation, sql) -%}
   {%- set _properties = config.get('properties') -%}
-  create table {{ relation }}
+
+  {%- set contract_config = config.get('contract') -%}
+  {%- if contract_config.enforced -%}
+
+  create table
+    {{ relation }}
+    {{ get_table_columns_and_constraints() }}
+    {{ get_assert_columns_equivalent(sql) }}
+    {%- set sql = get_select_subquery(sql) %}
     {{ properties(_properties) }}
-  as (
-    {{ sql }}
-  );
+  ;
+
+  insert into {{ relation }}
+    (
+      {{ sql }}
+    )
+  ;
+
+  {%- else %}
+
+    create table {{ relation }}
+      {{ properties(_properties) }}
+    as (
+      {{ sql }}
+    );
+
+   {%- endif %}
 {% endmacro %}
 
 
@@ -108,6 +130,10 @@
   {% endif %}
   create or replace view
     {{ relation }}
+  {%- set contract_config = config.get('contract') -%}
+  {%- if contract_config.enforced -%}
+    {{ get_assert_columns_equivalent(sql) }}
+  {%- endif %}
   security {{ view_security }}
   as
     {{ sql }}

dev_requirements.txt

@@ -1,4 +1,4 @@
-dbt-tests-adapter~=1.4.5
+dbt-tests-adapter~=1.5.0rc2
 mypy==1.2.0  # patch updates have historically introduced breaking changes
 pre-commit~=3.2
 pytest~=7.2

tests/functional/adapter/constraints/fixtures.py

@@ -0,0 +1,119 @@
+# model breaking constraints
+trino_model_char_value_to_int_column = """
+{{
+  config(
+    materialized = "table"
+  )
+}}
+
+select
+  -- char value for 'id', which is integer type
+  'char_value' as id,
+  -- change the color as well (to test rollback)
+  'red' as color,
+  '2019-01-01' as date_day
+"""
+
+trino_model_schema_yml = """
+version: 2
+models:
+  - name: my_model
+    config:
+      contract:
+        enforced: true
+    columns:
+      - name: id
+        quote: true
+        data_type: integer
+        description: hello
+        constraints:
+          - type: check
+            expression: (id > 0)
+        tests:
+          - unique
+      - name: color
+        data_type: varchar
+      - name: date_day
+        data_type: varchar
+  - name: my_model_error
+    config:
+      contract:
+        enforced: true
+    columns:
+      - name: id
+        data_type: integer
+        description: hello
+        constraints:
+          - type: check
+            expression: (id > 0)
+        tests:
+          - unique
+      - name: color
+        data_type: varchar
+      - name: date_day
+        data_type: varchar
+  - name: my_model_wrong_order
+    config:
+      contract:
+        enforced: true
+    columns:
+      - name: id
+        data_type: integer
+        description: hello
+        constraints:
+          - type: check
+            expression: (id > 0)
+        tests:
+          - unique
+      - name: color
+        data_type: varchar
+      - name: date_day
+        data_type: varchar
+  - name: my_model_wrong_name
+    config:
+      contract:
+        enforced: true
+    columns:
+      - name: id
+        data_type: integer
+        description: hello
+        constraints:
+          - type: check
+            expression: (id > 0)
+        tests:
+          - unique
+      - name: color
+        data_type: varchar
+      - name: date_day
+        data_type: varchar
+"""
+
+trino_constrained_model_schema_yml = """
+version: 2
+models:
+  - name: my_model
+    config:
+      contract:
+        enforced: true
+    constraints:
+      - type: check
+        expression: (id > 0)
+      - type: primary_key
+        columns: [ id ]
+      - type: unique
+        columns: [ color, date_day ]
+        name: strange_uniqueness_requirement
+    columns:
+      - name: id
+        quote: true
+        data_type: integer
+        description: hello
+        constraints:
+          - type: not_null
+        tests:
+          - unique
+      - name: color
+        data_type: varchar
+      - name: date_day
+        data_type: varchar
+"""