Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: enhancement-322-Add-retry-mechanism-for-the-given-error #323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ docker/dbt/.user.yml
.DS_Store
.vscode/
logs/
venv
34 changes: 29 additions & 5 deletions dbt/adapters/trino/connections.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import decimal
import os
import re
import time
from abc import ABCMeta, abstractmethod
from contextlib import contextmanager
from dataclasses import dataclass, field
Expand Down Expand Up @@ -505,11 +506,34 @@ def add_query(self, sql, auto_begin=True, bindings=None, abridge_sql_log=False):

return connection, cursor

def execute(self, sql, auto_begin=False, fetch=False):
_, cursor = self.add_query(sql, auto_begin)
status = self.get_response(cursor)
table = self.get_result_from_cursor(cursor)
return status, table
def execute(
self,
sql: str,
auto_begin: bool = False,
fetch: bool = False,
max_retries=trino.constants.DEFAULT_MAX_ATTEMPTS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trino.constants.DEFAULT_MAX_ATTEMPTS is for connection timeout issues

retry_delay: int = 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dataders can we pass a specific error message, retry_delay and max_retries from model configuration to here?

):
retry_count = 0
while retry_count < max_retries:
try:
_, cursor = self.add_query(sql, auto_begin)
status = self.get_response(cursor)
table = self.get_result_from_cursor(cursor)
return status, table

except DbtDatabaseError:
retry_count += 1
if retry_count < max_retries:
time.sleep(retry_delay)
logger.info(f"Retrying query ({retry_count}/{max_retries})...")
else:
raise

except Exception as exc:
raise exc

raise DbtRuntimeError("Failed to execute the query after maximum retries.")

@classmethod
def data_type_code_to_name(cls, type_code) -> str:
Expand Down
Loading