Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sync_all_columns schema change strategy for incremental models #324

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix sync_all_columns schema change strategy for incremental models #324

merged 1 commit into from
Jul 17, 2023

Conversation

posulliv
Copy link
Member

@posulliv posulliv commented Jul 12, 2023 •
edited
Loading

Overview

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • README.md updated and added information about my change
  • I have run changie new to create a changelog entry

@willmostly
Copy link
Member

Commenting to add myself as a listener

@hovaesco
Copy link
Member

Please add a change log entry https://github.com/starburstdata/dbt-trino/blob/master/CONTRIBUTING.md#adding-changelog-entry

@posulliv
Copy link
Member Author

@hovaesco ok done. Let me know if I did not do it correctly. I have not used changie before.

@posulliv posulliv mentioned this pull request Jul 13, 2023
Closed
1 task
@damian3031 damian3031 merged commit b5fd49a into starburstdata:master Jul 17, 2023
8 checks passed
@posulliv posulliv deleted the schema-changes branch July 17, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdesmet mdesmet mdesmet approved these changes

@hovaesco hovaesco hovaesco approved these changes

@damian3031 damian3031 damian3031 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@posulliv @willmostly @hovaesco @mdesmet @damian3031