Support for persist_docs #77
Conversation
hovaesco
force-pushed
the
hovaesco/persist-docs
branch
3 times, most recently
from
38ed99d
to
8793b42
Compare
hovaesco
requested review from
mdesmet and
findinpath
and removed request for
mdesmet
| {% macro trino__alter_relation_comment(relation, relation_comment) -%} | ||
| comment on {{ relation.type }} {{ relation }} IS '{{ relation_comment | replace("'", "''") }}'; | ||
| {% endmacro %} | ||
|
|
There was a problem hiding this comment.
Two new lines are present after each macro in this file.
|
|
||
| {% macro trino__alter_column_comment(relation, column_dict) %} | ||
| {% set existing_columns = adapter.get_columns_in_relation(relation) | map(attribute="name") | list %} | ||
| {% for column_name in column_dict if (column_name in existing_columns) %} |
There was a problem hiding this comment.
are we supposed to remove column comments as well when they are not set anymore?
same question for tables.
There was a problem hiding this comment.
Comments are deleted if there are no set anymore. It's done by setting an empty comment
There was a problem hiding this comment.
The removal of comments is done by the command
COMMENT ON TABLE/COLUMN ... IS NULL
There was a problem hiding this comment.
Thanks, the code adjusted accordingly to the comment.
| "name": "persist_docs_tests", | ||
| "models": { | ||
| "+persist_docs": { | ||
| "relation": True |
There was a problem hiding this comment.
we basically test whether dbt is persisting docs for relations and columns, but can we check whether the comments were set as expected on the underlying database?
There was a problem hiding this comment.
Thanks for a valid comment. This test should be handled by macro https://github.com/starburstdata/dbt-trino/blob/master/dbt/include/trino/macros/catalog.sql which creates a file target/catalog.json generated by dbt docs generate command.
In the get_catalog macro table and column comments are returned as null. Information schema tables in Trino miss comment columns. I will create a follow-up ticket in Trino for it.
Docs are generated by a file located in target/manifest.json and all comments are present in dbt-docs and persisted in the Trino.
hovaesco
force-pushed
the
hovaesco/persist-docs
branch
from
8793b42
to
8f30cb9
Compare
hovaesco
force-pushed
the
hovaesco/persist-docs
branch
from
8f30cb9
to
e95cf44
Compare
hovaesco
force-pushed
the
hovaesco/persist-docs
branch
from
e95cf44
to
5702413
Compare
Overview
Checklist
README.mdupdated and added information about my changeCHANGELOG.mdupdated and added information about my change