Switch to Metabase v1.48.3 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpoulain
force-pushed
the
upgrade-to-metabase-149
branch
2 times, most recently
from
94bdfa4
to
a7cad00
Compare
|
👀 |
andrewdibiasio6
approved these changes
Feb 14, 2024
| @@ -33,7 +33,7 @@ | |||
| :native-parameters true | |||
| :expression-aggregations true | |||
| :binning true | |||
| :foreign-keys true | |||
| :foreign-keys false | |||
There was a problem hiding this comment.
Is there a doc for this for my reference?
There was a problem hiding this comment.
No Metabase doc. I realized this when I found that all the tests checking foreign keys failed. And it turns out that, when using the Trino JDBC driver, DatabaseMetaData.getImportedKeys() doesn't appear to work.
There was a problem hiding this comment.
I meant do that says Trino does not support Foreign Keys. I just can't find it in the official docs.
There was a problem hiding this comment.
One thing I'm researching in parallel is how come Presto Metabase driver supports foreign keys. It may be possible to have the Starburst driver support foreign keys, but it appears it never had.
Switch to Metabase v1.48.3
lpoulain
force-pushed
the
upgrade-to-metabase-149
branch
from
a7cad00
to
a29f529
Compare
andrewdibiasio6
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to Metabase v1.48.3. The following changes were made, as many new Metabase tests were added:
have-select-privilege?was replaced withsql-jdbc.sync.interface/have-select-privilege?as some tests could not find it. The test was also modified as the previous version didn't execute the actual querytoucan.db(deprecated) withtoucan2.core:foreign-keysdriver_test.cljwhich removes those two tests which are not relevant to Starburst