Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Use a new metric for sync select head and rename networkp2p metrics #2987

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Oct 26, 2021

  1. 新增 chain_select_head_total, 保证 chain_block_connect_total 的每种类型总和是 100%,方便出饼图。
  2. 重命名部分 networkp2p 的 metrics。

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #2987 (0448e5a) into master (17a440e) will increase coverage by 0.06%.
The diff coverage is 11.12%.

❗ Current head 0448e5a differs from pull request most recent head 391ca23. Consider uploading reports for the commit 391ca23 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2987      +/-   ##
==========================================
+ Coverage   33.33%   33.39%   +0.06%     
==========================================
  Files         515      515              
  Lines       45688    45692       +4     
  Branches    20831    20833       +2     
==========================================
+ Hits        15225    15253      +28     
- Misses      16041    16153     +112     
+ Partials    14422    14286     -136     
Flag Coverage Δ
unittests 33.39% <11.12%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sync/src/block_connector/write_block_chain.rs 30.00% <0.00%> (+1.00%) ⬆️
sync/src/block_connector/metrics.rs 30.31% <16.67%> (-6.73%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
network-rpc/core/src/lib.rs 23.53% <0.00%> (-5.88%) ⬇️
cmd/starcoin/src/cli_state.rs 47.37% <0.00%> (-5.26%) ⬇️
cmd/starcoin/src/dev/tests.rs 14.44% <0.00%> (-4.12%) ⬇️
types/src/startup_info.rs 64.23% <0.00%> (-3.66%) ⬇️
txpool/src/pool/listener/tests.rs 10.91% <0.00%> (-3.63%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a440e...391ca23. Read the comment docs.

@jolestar jolestar changed the title [metrics] Use a new metric for sync select head. [metrics] Use a new metric for sync select head and rename networkp2p metrics Oct 26, 2021
@jolestar jolestar merged commit 6227d9a into master Oct 27, 2021
@jolestar jolestar deleted the metric_select_head branch October 27, 2021 04:26
@jolestar jolestar linked an issue Oct 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework on metrics
2 participants