-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement account provider #3259
Conversation
the private key provider can implement by local db provider through import key. |
Codecov Report
@@ Coverage Diff @@
## master #3259 +/- ##
==========================================
+ Coverage 31.78% 31.98% +0.21%
==========================================
Files 493 499 +6
Lines 46062 46240 +178
Branches 21152 21215 +63
==========================================
+ Hits 14635 14787 +152
+ Misses 17429 17425 -4
- Partials 13998 14028 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- cmd 的集成测试现在临时被注释掉了,可以在本地运行一下,确保命令行兼容没问题。
- 进一步需要增加一些 local provider 的测试用例。
- 需要补充一些 local provider 的使用文档(Readme.md 里的例子也可以更新一下)。
Benchmark for e36339eClick to view benchmark
|
Benchmark for 3f64cffClick to view benchmark
|
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information