Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stratum client issue #3362

Merged
merged 1 commit into from Apr 22, 2022
Merged

Fix stratum client issue #3362

merged 1 commit into from Apr 22, 2022

Conversation

sanlee42
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@sanlee42 sanlee42 closed this Apr 22, 2022
@sanlee42 sanlee42 reopened this Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #3362 (b0a1de2) into master (4652f82) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3362      +/-   ##
==========================================
- Coverage   32.18%   31.90%   -0.28%     
==========================================
  Files         500      500              
  Lines       46814    46814              
  Branches    21311    21311              
==========================================
- Hits        15063    14930     -133     
+ Misses      17732    17731       -1     
- Partials    14019    14153     +134     
Flag Coverage Δ
unittests 31.90% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/miner_client/src/stratum_client_service.rs 0.00% <0.00%> (ø)
executor/src/block_executor.rs 22.23% <0.00%> (-15.55%) ⬇️
consensus/src/dummy.rs 69.57% <0.00%> (-13.04%) ⬇️
chain/src/verifier/mod.rs 36.72% <0.00%> (-11.71%) ⬇️
vm/types/src/on_chain_config/mod.rs 42.47% <0.00%> (-10.95%) ⬇️
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
chain/open-block/src/lib.rs 31.79% <0.00%> (-9.27%) ⬇️
vm/types/src/transaction_metadata.rs 56.72% <0.00%> (-7.46%) ⬇️
vm/natives/src/account.rs 25.00% <0.00%> (-6.25%) ⬇️
vm/vm-runtime/src/starcoin_vm.rs 37.01% <0.00%> (-5.19%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4652f82...b0a1de2. Read the comment docs.

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/starcoinorg/starcoin/pull/3362/files#diff-312fa06630778cef51a3c02ff84a3f74c09f8237d9fb8abb417a509c53006f25R301

//FIXME: Failed to receive this msg since upgrade actix to 0.13.

是不是可以删掉了?问题应该不在那边。

@jolestar jolestar linked an issue Apr 22, 2022 that may be closed by this pull request
@sanlee42 sanlee42 merged commit 0203e79 into master Apr 22, 2022
@sanlee42 sanlee42 deleted the fix_stratum branch April 22, 2022 09:16
@jolestar jolestar requested a review from LemonHX April 22, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] miner_client can not submit seal
2 participants