Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdlib to latest #3783

Merged
merged 2 commits into from Oct 14, 2022
Merged

Update stdlib to latest #3783

merged 2 commits into from Oct 14, 2022

Conversation

sanlee42
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@sanlee42 sanlee42 enabled auto-merge (squash) October 14, 2022 04:57
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #3783 (a29257c) into master (3a8548f) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3783      +/-   ##
==========================================
+ Coverage   53.66%   53.71%   +0.05%     
==========================================
  Files         594      594              
  Lines       64148    64148              
==========================================
+ Hits        34419    34450      +31     
+ Misses      29729    29698      -31     
Flag Coverage Δ
unittests 53.71% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network-p2p/src/request_responses.rs 83.81% <0.00%> (-0.86%) ⬇️
sync/src/sync.rs 61.84% <0.00%> (+0.23%) ⬆️
vm/compiler/src/lib.rs 77.64% <0.00%> (+0.44%) ⬆️
...rc/protocol/generic_proto/upgrade/notifications.rs 90.89% <0.00%> (+0.54%) ⬆️
network-p2p/src/out_events.rs 84.82% <0.00%> (+0.64%) ⬆️
network-p2p/src/discovery.rs 73.61% <0.00%> (+1.53%) ⬆️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 77.34% <0.00%> (+7.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8548f...a29257c. Read the comment docs.

@github-actions
Copy link

Benchmark for 5e32c55

Click to view benchmark
Test Base PR %
accumulator_append 603.9±31.51µs 606.3±27.92µs +0.40%
block_apply/block_apply_10 846.9±1.13ms 837.6±2.37ms -1.10%
block_apply/block_apply_1000 85.9±0.06s 84.6±0.08s -1.51%
get_with_proof/db_store 36.5±0.16µs 36.1±0.38µs -1.10%
get_with_proof/mem_store 32.0±2.69µs 31.5±0.46µs -1.56%
put_and_commit/db_store/1 95.6±4.71µs 96.0±4.88µs +0.42%
put_and_commit/db_store/10 853.7±36.45µs 855.5±38.05µs +0.21%
put_and_commit/db_store/100 7.3±0.29ms 7.3±0.29ms 0.00%
put_and_commit/db_store/5 441.4±20.80µs 438.4±21.93µs -0.68%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.5±5.82µs 61.6±5.68µs +0.16%
put_and_commit/mem_store/10 573.7±46.42µs 575.2±47.72µs +0.26%
put_and_commit/mem_store/100 5.6±0.34ms 5.7±0.84ms +1.79%
put_and_commit/mem_store/5 290.4±24.65µs 290.5±24.49µs +0.03%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 6.6±0.26ms 6.8±0.25ms +3.03%
query_block/query_block_in(10)_times(1000) 66.2±1.51ms 68.4±1.84ms +3.32%
query_block/query_block_in(10)_times(10000) 666.8±18.46ms 681.1±15.82ms +2.14%
query_block/query_block_in(1000)_times(100) 1006.8±10.94µs 990.6±16.02µs -1.61%
query_block/query_block_in(1000)_times(1000) 10.1±0.08ms 9.9±0.13ms -1.98%
query_block/query_block_in(1000)_times(10000) 101.4±1.28ms 98.8±1.02ms -2.56%
storage_transaction 1069.6±276.21µs 1089.3±345.03µs +1.84%
vm/transaction_execution/1 949.2±1.61ms 950.5±1.22ms +0.14%
vm/transaction_execution/10 235.5±0.45ms 238.7±0.79ms +1.36%
vm/transaction_execution/20 202.0±0.52ms 204.6±0.36ms +1.29%
vm/transaction_execution/5 312.5±1.06ms 315.2±1.06ms +0.86%
vm/transaction_execution/50 217.7±0.53ms 221.6±3.60ms +1.79%

@sanlee42 sanlee42 requested a review from nkysg as a code owner October 14, 2022 06:28
@sanlee42 sanlee42 merged commit a80c83a into master Oct 14, 2022
@sanlee42 sanlee42 deleted the update_stdlib branch October 14, 2022 06:58
@github-actions
Copy link

Benchmark for 1e5707c

Click to view benchmark
Test Base PR %
accumulator_append 602.4±31.27µs 607.5±30.19µs +0.85%
block_apply/block_apply_10 838.5±1.73ms 839.8±1.65ms +0.16%
block_apply/block_apply_1000 84.9±0.05s 85.5±0.05s +0.71%
get_with_proof/db_store 36.6±0.25µs 36.9±0.58µs +0.82%
get_with_proof/mem_store 31.7±0.16µs 31.8±0.23µs +0.32%
put_and_commit/db_store/1 95.6±4.92µs 96.0±4.83µs +0.42%
put_and_commit/db_store/10 855.6±38.16µs 857.4±37.13µs +0.21%
put_and_commit/db_store/100 7.3±0.33ms 7.3±0.30ms 0.00%
put_and_commit/db_store/5 435.4±20.54µs 442.3±32.35µs +1.58%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.9±5.73µs 61.5±5.67µs -0.65%
put_and_commit/mem_store/10 582.8±52.56µs 579.9±49.30µs -0.50%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.83ms 0.00%
put_and_commit/mem_store/5 292.7±24.67µs 292.9±26.03µs +0.07%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 6.7±0.39ms 6.9±0.33ms +2.99%
query_block/query_block_in(10)_times(1000) 66.2±2.03ms 67.5±2.44ms +1.96%
query_block/query_block_in(10)_times(10000) 670.9±11.07ms 672.4±12.68ms +0.22%
query_block/query_block_in(1000)_times(100) 998.5±44.91µs 995.0±16.63µs -0.35%
query_block/query_block_in(1000)_times(1000) 9.9±0.15ms 9.9±0.08ms 0.00%
query_block/query_block_in(1000)_times(10000) 98.7±1.30ms 98.9±1.47ms +0.20%
storage_transaction 1100.7±352.27µs 1099.3±353.13µs -0.13%
vm/transaction_execution/1 946.3±1.10ms 951.6±4.93ms +0.56%
vm/transaction_execution/10 235.1±1.22ms 238.4±0.69ms +1.40%
vm/transaction_execution/20 201.3±1.64ms 205.1±0.90ms +1.89%
vm/transaction_execution/5 312.5±3.87ms 315.6±1.95ms +0.99%
vm/transaction_execution/50 216.9±0.81ms 222.1±3.03ms +2.40%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants