Resolve integer overflow when running on a large 3D image #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a computation like x+y*nx+z*(nx*ny) if the sub-computation y*nx or z*(nx*ny) overflows the size of a 32-bit integer, we will get a bogus result even though the final destination is a 64-bit integer. The solution is to promote at least one operand to a bigger-sized integer. Since long can also be 32-bit on 32-bit architectures, we just use explicit named types here. This patch also fixes a few cases of comparisons of integers with different signs. Resolves: stardist#235
|
Indeed all indices/offsets should have been uint64 anyway, so this is a good fix. Thanks! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In a computation like x+ynx+z(nxny) if the sub-computation ynx or z*(nx*ny) overflows the size of a 32-bit integer, we will get a bogus result even though the final destination is a 64-bit integer (since all the operands are 32-bit ints). The solution is to promote at least one operand to a bigger-sized integer. Since long can also be 32-bit on 32-bit architectures, we just use explicit named types here.
This patch also fixes a few cases of comparisons of integers with different signs.
Resolves: #235