Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the stardog.properties configmap #64

Merged
merged 7 commits into from
Nov 12, 2021

Conversation

MrMunki
Copy link
Contributor

@MrMunki MrMunki commented Oct 7, 2021

Updated the configmap to allow additional settings to be added to the stardog.properties, aas per "Enhancement Request: configure stardog.properties in values #50"

@MrMunki MrMunki mentioned this pull request Oct 11, 2021
Copy link
Contributor

@igable igable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review on this PR. This looks like a great addition, thanks very much.

I would like to suggest that for additional properties that you actually pass a text blobs because of the confusion/usability challenges of having keys containing dots when dots are also used to indicate nesting in helm values. For example when using --set ( some details on that here)

So you could then pass like this:

additionalStardogProperties: |

  query.timeout = 5m
  pack.rejoin.shutdown = false
  password.length.min = 10

Then template side do something like this:

{{- .Values.additionalStardogProperties | nindent 4 }}

How does that sound?

@MrMunki
Copy link
Contributor Author

MrMunki commented Oct 27, 2021

Hi, I've updated the config as you described.

@MrMunki MrMunki requested a review from igable October 27, 2021 12:17
@scardena scardena merged commit 32530e3 into stardog-union:develop Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants