Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Icon): add hands icon in teams theme #1567

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Conversation

t-proko
Copy link
Contributor

@t-proko t-proko commented Jul 1, 2019

Problem description
Please port the new ubar icons for raise hands to StarDust
raisehands

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #1567 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
- Coverage   71.64%   71.57%   -0.07%     
==========================================
  Files         844      844              
  Lines        6891     6864      -27     
  Branches     1960     1947      -13     
==========================================
- Hits         4937     4913      -24     
+ Misses       1948     1945       -3     
  Partials        6        6
Impacted Files Coverage Δ
...rc/themes/teams/components/Icon/svg/icons/hand.tsx 100% <100%> (ø)
.../components/Icon/svg/ProcessedIcons/icons-hand.tsx 100% <100%> (ø)
...ges/react/src/components/Attachment/Attachment.tsx 42.3% <0%> (-35.48%) ⬇️
packages/react/src/components/Toolbar/Toolbar.tsx 89.47% <0%> (-1.01%) ⬇️
packages/react/src/index.ts 100% <0%> (ø) ⬆️
...hemes/teams/components/Toolbar/toolbarVariables.ts 50% <0%> (ø) ⬆️
...eams/components/Toolbar/toolbarCustomItemStyles.ts
...react/src/components/Toolbar/ToolbarCustomItem.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e997408...8c83de5. Read the comment docs.

@mnajdova
Copy link
Contributor

mnajdova commented Jul 2, 2019

Please update the changelog under Unreleased -> Features section, something like:

After that, accept the screener differences and it should be good for merge.

@mnajdova mnajdova changed the title icons for raise hands in the calling screen feat(Icon): add hands icon in teams theme Jul 2, 2019
@mnajdova mnajdova merged commit 5fd957c into microsoft:master Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants