This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(doc): Use correct LTR/RTL Fela renderer in renderComponent #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
- Coverage 82.86% 82.84% -0.03%
==========================================
Files 59 59
Lines 846 845 -1
Branches 183 182 -1
==========================================
- Hits 701 700 -1
Misses 141 141
Partials 4 4
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Aug 1, 2018
| @@ -36,22 +36,26 @@ class Provider extends Component<any, any> { | |||
|
|
|||
| static Consumer = ProviderConsumer | |||
|
|
|||
| renderStaticStyles = felaRenderer => { | |||
| renderStaticStyles = () => { | |||
| // RTL WARNING | |||
There was a problem hiding this comment.
maybe it would be a good idea to include reference on docs where it is stated that
no further processing with plugins will be done for static styles
There was a problem hiding this comment.
Thanks, link added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24
RTL component preview in Docs
When component preview in Docs is switched to RTL, two things happen:
<div dir="rtl">.The problem was that
getClasses()used hardcoded LTR Fela renderer regardless the switch.Now renderer is added to fela theme and
getClasses()uses the renderer from the theme (via context).TODO