This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR aims to address the following warning that prevents bits from being published:
Cause
Root cause of this problem is that
typescript
bits are exported different way for compiler of version 3.1.* - specifically, dynamic import expressions are used for modules (examples provided below) that drives webpack into frustration (webpack/webpack#196).And even given that production bundle size had remained to be almost exactly the same (7.35 -> 7.47MB), this fact results in webpack warning that fails build.
Was
Now
Solution
Use
ContextReplacementPlugin
to explicitly suggest the files that should be statically analysed by Webpack for bundling. With this approach--skipLibCheck
requirement from client's projects