Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Feat/multi dropdown component #422

Merged
merged 87 commits into from
Dec 10, 2018
Merged

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Nov 2, 2018

Focus on creating the multiple pick dropdown.

Issue: #388

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b6450d4). Click here to learn what that means.
The diff coverage is 40%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #422   +/-   ##
========================================
  Coverage          ?   80.1%           
========================================
  Files             ?      46           
  Lines             ?    1749           
  Branches          ?     243           
========================================
  Hits              ?    1401           
  Misses            ?     343           
  Partials          ?       5
Impacted Files Coverage Δ
src/components/List/List.tsx 61.66% <ø> (ø)
src/components/Slot/Slot.tsx 100% <100%> (ø)
src/index.ts 100% <100%> (ø)
src/components/Dropdown/Dropdown.tsx 33.33% <33.33%> (ø)
src/components/Dropdown/DropdownLabel.tsx 39.39% <39.39%> (ø)
src/components/Dropdown/DropdownSearchInput.tsx 51.72% <51.72%> (ø)
src/components/Dropdown/DropdownItem.tsx 65.21% <65.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6450d4...d854fc7. Read the comment docs.

package.json Outdated Show resolved Hide resolved
src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
src/components/Dropdown/Dropdown.tsx Show resolved Hide resolved
@miroslavstastny
Copy link
Member

It also drops down under code editor in docsite:
image

@silviuaavram silviuaavram self-assigned this Nov 8, 2018
@joheredi joheredi mentioned this pull request Nov 9, 2018
@silviuaavram silviuaavram force-pushed the feat/multi-dropdown-component branch 2 times, most recently from 017a177 to 3f2b0ad Compare November 19, 2018 14:31
@bmdalex
Copy link
Collaborator

bmdalex commented Dec 6, 2018

@kuzhelov kuzhelov closed this Dec 10, 2018
@kuzhelov kuzhelov reopened this Dec 10, 2018
@kuzhelov kuzhelov dismissed bmdalex’s stale review December 10, 2018 01:58

seems that currently all issues that were raised are addressed

@kuzhelov kuzhelov merged commit d9648ed into master Dec 10, 2018
@layershifter layershifter deleted the feat/multi-dropdown-component branch January 10, 2019 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Core Team
  
silviuavram
Development

Successfully merging this pull request may close these issues.

None yet

8 participants