This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Provider): correctly handle change of renderer #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
approved these changes
Jan 11, 2019
…ithub.com/stardust-ui/react into fix/provide-dymanic-render
…x/provide-dymanic-render
layershifter
added
🚀 ready for review
🧰 fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #581.
After
react-felais not handling therendererprop change on component, robinweser/fela#388, #581 (comment).render()vskeychange onRendererProviderWhen we changing a
keyprop value, we will remount the whole tree.render()is a pretty safe and fast function, it will create a DOM subscription only once, fela-dom/src/dom/render.js.The
render()function cannot be called incomponentDidMount()as a side effect becausefelacreates CSS classes directly in component's render cycle.