You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Stardust component will be improperly displayed in RTL mode if rtl flag is changed dynamically for parent Provider component - i.e. when there is no remount of Provider component's instance happened.
Specifically, the root cause of this issue is absence of remount for Fela's Provider component.
Steps
create simple example and render Stardust Button component
import{Provider,Button}from'@stardust-ui/react'// use any theme which has `rtl` being set to false by default<Providertheme={teams}><Button/></Provider>
open React Dev Tools, and for Stardust Provider component check rtl box to true
Expected Result
rtl-* classes should be generated in <head> -> <style> DOM element
rtl-* should be applied to component's DOM node
Actual Result
👍 rtl-* ARE applied to component's DOM node`
👎 but there are no corresponding rtl-* classes generated for <head> -> <style> DOM element of the page - thus, styles of these classes are not applied to component
Bug Report
Stardust component will be improperly displayed in RTL mode if
rtlflag is changed dynamically for parentProvidercomponent - i.e. when there is no remount ofProvidercomponent's instance happened.Specifically, the root cause of this issue is absence of remount for Fela's
Providercomponent.Steps
ButtoncomponentProvidercomponent checkrtlbox totrueExpected Result
rtl-*classes should be generated in<head> -> <style>DOM elementrtl-*should be applied to component's DOM nodeActual Result
rtl-*ARE applied to component's DOM node`rtl-*classes generated for<head> -> <style>DOM element of the page - thus, styles of these classes are not applied to componentVersion
0.14.0