Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RSS-ECOMM-2_29): fix router #115

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix(RSS-ECOMM-2_29): fix router #115

merged 2 commits into from
Apr 30, 2024

Conversation

Kleostro
Copy link
Collaborator

@Kleostro Kleostro commented Apr 30, 2024 •
edited
Loading

PR Title ✨

📍 conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. RSS-ECOMM-2_01, where 2 - is the sprint number and 01 - is the issue number)
  • short description

👀 Example: feat(RSS-ECOMM-2_01): description

PR Description 🧙‍♂️

  • Fix logic Router component.

Provide any other relevant information 🦉

  • Add logic for switching page visibility.

Self-Check 🌟

  • I wrote the correct title for the PR 🗝️
  • I wrote the correct description for the PR 📜
  • I have performed a self-review of my own code ✅
  • I have commented my code where needed 📝
  • My code is formatted correctly and passes the check 🎨
  • My code passes the tests check ⛓️
  • My code successfully builds ⚙️
  • I am happy with my PR and ready to merge ❤️‍🔥

@stardustmeg stardustmeg added the feature New feature or request label Apr 30, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited
Loading

✅ Deploy Preview for mad-wizards-greenshop-develop ready!

Name Link
🔨 Latest commit 3819a21
🔍 Latest deploy log https://app.netlify.com/sites/mad-wizards-greenshop-develop/deploys/663154834c0b39000868921e
😎 Deploy Preview https://deploy-preview-115--mad-wizards-greenshop-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was linked to issues Apr 30, 2024
[sprint_2] Issue RSS-ECOMM-2_29: Fix Router 📄 #114
Closed
[sprint_2] Issue RSS-ECOMM-2_08: Add a button to navigate to the registration page 🖱️ #82
Closed
@Kleostro Kleostro merged commit c8e5443 into sprint-2 Apr 30, 2024
8 checks passed
@stardustmeg
Copy link
Owner

[sprint_2] Issue RSS-ECOMM-2_08: Add a button to navigate to the registration page 🖱️

@stardustmeg
Copy link
Owner

[sprint_2] Issue RSS-ECOMM-2_29: Fix Router 📄

Repository owner deleted a comment from Kleostro Apr 30, 2024
@stardustmeg stardustmeg deleted the fix(RSS-ECOMM-2_29)/fixRouter branch April 30, 2024 23:01
@stardustmeg stardustmeg mentioned this pull request May 4, 2024
Closed
stardustmeg added a commit that referenced this pull request May 6, 2024
@stardustmeg @Kleostro @YulikK
eCommerce-Application [sprint 2] (#180)
ede8d3d 
* feat(RSS-ECOMM-2_24): add App component (#106)

* test(RSS-ECOMM-2_25): add tests for App component (#108)

* docs(RSS-ECOMM-2_26): update PR template for second sprint

* feat(RSS-ECOMM-2_27): add pages components (#109)

* feat: add LoginPage component

* feat: add MainPage component

* refactor: rename the loginPageView field to view

* feat: add RegistrationPage component

* feat: add NotFoundPage component

* fix: fix name MainPage component

* feat(RSS-ECOMM-2_28): add router component (#111)

* feat: add Router component

* feat: add environment variables

* feat: add EventMediator component

* feat(RSS-ECOMM-2_01): implement client side validation for login form (#112)

* feat: add InputField component

* feat: add InputFieldValidator component

* feat: add types for InputField component

* feat: add LoginForm component

* feat: add the necessary validators to check input fields

* feat: add password display functionality

* fix: changes from @stardustmeg

Co-authored-by: Meg G. <146496794+stardustmeg@users.noreply.github.com>

* fix: changes from @stardustmeg

Co-authored-by: Meg G. <146496794+stardustmeg@users.noreply.github.com>

---------

Co-authored-by: Meg G. <146496794+stardustmeg@users.noreply.github.com>

* feat(RSS-ECOMM-2_02): add pages style (#113)

* feat: add elements from the layout for the LoginPage

* feat: add styles for LoginPage

* feat: add styles for LoginForm

* feat: add hover for register link

* fix(RSS-ECOMM-2_29): fix router (#115)

* feat: add logic for switching page visibility

* fix: fix logic Router component

* feat(RSS-ECOMM_2-03): customer Model with server requests (#117)

* feat: add root class, and request to server

* feat: add CustomerModel for get and set Customer info

* feat: change params in editCustomer function

* fix: syntax error

* feat(RSS-ECOMM-2_09): add registration form (#116)

* feat: add RegistrationForm component

* feat: add validation RegistrationForm

* feat: add new validators for RegistrationForm

* feat: add logic for selecting a country from a predefined list

* feat: add saving selected country in store

* feat: add validate postal code and country input fields

* fix: change description registration form

* feat(RSS-ECOMM-2_05): add redirect to main page from login page (#119)

* feat: add saving current user data to store

* feat: add submit correct form

* feat: add ErrorMessage component

* feat: add redirect to main page on login

* feat(RSS-ECOMM-2_06): add redirect auth user (#120)

* feat: implement LocalStorage

* feat: add redirect auth user to main page

* feat(RSS-ECOMM-2_20): implement not found page (#121)

* feat: implement not found page

* feat: implement saving route when Not Found is open

* feat(RSS-ECOMM-2_11): integrate registration form (#122)

* refactor: replace ErrorMessage component with ServerMessage

* refactor: added the ability to throw an error further into the code

* fix: fixed an error comparing the current and next version of user information

* feat: integrate new user registration

* fix: collecting registration form data

* feat(RSS-ECOMM-2_13): add relocate new user to main page after registration (#123)

* fix(RSS-ECOMM-2_32): update countries list

* fix(RSS-ECOMM-2_33): router component

* feat(RSS-ECOMM-2_14): set default address during registration (#131)

* feat: add CountryChoice component

* fix: postalCode validation

* feat: update state

* refactor: separate CountryChoice component into a module

* feat: add settings address by default

* refactor(RSS-ECOMM-2_38): refactor main codebase (#130)

* refactor: break types into separate modules

* refactor: remove redundant styles description imports

* refactor: break one constants module into separate ones

* refactor: separate single types module into several ones

* feat: add check email (#132)

* fix(RSS-ECOMM-2_39): refresh page (#133)

* chore(RSS-ECOMM-2_36): remove redundant files (#134)

* chore: delete .env.github

* chore: delete package-lock.json

* chore(RSS-ECOMM-2_40): update configs (#173)

* chore: update configs

* fix: gitignore not to add package-lock.json

* docs: add checks badges

* docs: update PR template structure

* docs: format the PR template

* docs: change the structure of PR temlate

* feat(RSS-ECOMM-2_15): set default address (#174)

* feat: add display required fields in register form

* feat: add checkbox for setting default address

* fix: delete interfaces file

* feat(RSS-ECOMM-2_16): add links on Login and Register pages (#175)

* feat(RSS-ECOMM-2_17): add links to all functional pages (#177)

* feat: add Link component

* feat: add header with

* feat: implement disabling links for user

* refactor: remove unnecessary styles

* feat(RSS-ECOMM-2_22): add header logo (#178)

* fix: disabling navigation links

* feat: add header styles

* feat: add navigation styles

* feat: add navigate on click logo to main page

* feat: add position sticky to header

* test(RSS-ECOMM-2_35): add tests for api requests, product and custom model (#176)

* test: add test for api, customer and product request

* test: change birthDate type to string, optimization adaptCustomer functions

* fix(RSS-ECOMM-2_41): reload page (#179)

* feat(RSS-ECOMM-2_23): add logout button (#181)

* feat(RSS-ECOMM-2_34): update app title (#182)

* feat(RSS-ECOMM-2_43): implement footer (#183)

* fix(RSS-ECOMM2_44): fix styles (#185)

* fix: fade-in/fade-out styles

* fix: delete redundant common styles

* fix: header styles

* refactor: set the animation delay to a constant

* Apply suggestions from code review

Co-authored-by: Meg G. <146496794+stardustmeg@users.noreply.github.com>

* chore: run prettier

---------

Co-authored-by: Meg G. <146496794+stardustmeg@users.noreply.github.com>

* test(RSS-ECOMM-2_45): cover main code base (#186)

* test(RSS-ECOMM-2_42): cover codebase (#187)

* test: cover store actions

* test: cover store observer

* test: cover store reducer

* feat(RSS-ECOMM-2_46): implement register api integration (#188)

* refactor: rename check email method

* feat: add handling API errors with login

* feat: sending request for registration form

* fix: sending registration requests

* refactor: sending registartion requests from the form

* feat: add type validation for user

* test: add tests for user type validation

* refactor: separate forms constans

* fix(RSS-ECOMM-2_47): display app title (#189)

fix: display app title

* feat(RSS-ECOMM-2_48): display error message from api (#190)

feat: display error message from api

* feat(RSS-ECOMM-2_49): implement Loader component (#192)

feat: implement Loader component

* fix(RSS-ECOMM-2_50): country choice wrapper on TAB (#193)

fix: country choice wrapper on TAB

* feat(RSS-ECOMM-2_30): implement language choice (#191)

* feat: implement switching countries droplist items language

* feat: implement switching languages on separate elements

* feat: implement switching registration form titles

* feat: add not found page description

* feat: implement changing links language

* chore: update lint-staged husky configuration

* feat: implement validation translation

* fix: change constant

* RSS ECOMM-3_09 - get product (#194)

* feat: add discount and refactor adapt price and discount functions

* feat: add setLocale action, add request for price range, count category product

* fix: merge

* feat(RSS-ECOMM-2_30): implement language choice (#195)

* feat: implement switching countries droplist items language

* feat: implement switching languages on separate elements

* feat: implement switching registration form titles

* feat: add not found page description

* feat: implement changing links language

* chore: update lint-staged husky configuration

* feat: implement validation translation

* fix: change constant

* fix: country validation

* feat: implement choosing language

---------

Co-authored-by: Max <133934232+Kleostro@users.noreply.github.com>
Co-authored-by: Yuliya Kursevich <54816946+YulikK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stardustmeg stardustmeg stardustmeg approved these changes

@YulikK YulikK Awaiting requested review from YulikK

Assignees
No one assigned
Labels
feature New feature or request fix sprint2 📑
Projects
None yet
Milestone
No milestone
2 participants
@Kleostro @stardustmeg