Feature plots description #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stared
reviewed
Jul 10, 2020
livelossplot/main_logger.py
Outdated
| @@ -24,10 +24,11 @@ def __init__( | |||
| current_step: int = -1, | |||
| auto_generate_groups_if_not_available: bool = True, | |||
| auto_generate_metric_to_name: bool = True, | |||
| group_patterns: List[Tuple[str, str]] = [ | |||
| group_patterns: List[Tuple[Pattern, str]] = [ | |||
| (r'^(?!val(_|-))(.*)', 'training '), | |||
There was a problem hiding this comment.
Here we shouldn't have space after (e.g. 'training' not 'training ').
stared
reviewed
Jul 10, 2020
livelossplot/main_logger.py
Outdated
Comment on lines
165
to
169
| def step_name(self, group_name: str) -> str: | ||
| if isinstance(self._step_names, str): | ||
| return self._step_names | ||
| else: | ||
| return self._step_names.get(group_name, 'epoch') |
There was a problem hiding this comment.
It is OK, but I think it would be more idiomatic to use DefaultDict (but it can stay as it is).
stared
reviewed
Jul 10, 2020
Comment on lines
+44
to
+46
| self._after_subplot = after_subplot if after_subplot else self._default_after_subplot | ||
| self._before_plots = before_plots if before_plots else self._default_before_plots | ||
| self._after_plots = after_plots if after_plots else self._default_after_plots |
stared
reviewed
Jul 10, 2020
Comment on lines
54
to
55
| clear_output(wait=True) | ||
| plt.figure(figsize=(figsize_x, figsize_y)) | ||
| self._before_plots(len(log_groups)) |
There was a problem hiding this comment.
clear_output should be in before_plots.
stared
requested changes
Jul 10, 2020
stared
reviewed
Jul 13, 2020
| ax.set_xlabel(x_label) | ||
| ax.legend(loc='center right') | ||
|
|
||
| def _default_before_plots(self, figure: plt.Figure, num_of_log_groups: int) -> None: |
There was a problem hiding this comment.
Here and in other places: it is idiomatic to use fig not figure.
stared
approved these changes
Jul 13, 2020
|
And one more thing: in Jupyter Notebook:
|
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist:
Notes:
step_name(group_name)function is more comfortable to handle default value than access to a pure dictionary