Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Try to reproduce and fix race condition (#1647) #1656

Closed
wants to merge 4 commits into from

Conversation

tatu-at-datastax
Copy link
Collaborator

What this PR does:

Which issue(s) this PR fixes:
Fixes #1647

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA


Awaitility.await()
.atMost(30, TimeUnit.SECONDS)
.untilAsserted(() -> assertThat(responses.size()).isEqualTo(2 * ROUNDS));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails here only getting 1000 -- but I don't think that actually reproduces the NPE we want to catch; both since no matching error found in logs and since suggested fix for QueryProcessor access does not solve the fail.
So I suspect assertion here is incorrect.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and as per my later comment, NPE not shown because PR did NOT UPDATE Cassandra dep which comes from different PR).

@ivansenic
Copy link
Contributor

@tatu-at-datastax I don't know what was the idea, but here you don't have upgrade to C* 4.0.2?

@tatu-at-datastax
Copy link
Collaborator Author

tatu-at-datastax commented Feb 24, 2022

@ivansenic Correct, the original PR (#1647) has that.

Ohh... shoot. I am an idiot. Wasted lots of time due to not upgrading version of 4.0.

@ivansenic
Copy link
Contributor

Let s close this one, you can port anything you want to the original PR.

@tatu-at-datastax
Copy link
Collaborator Author

Let s close this one, you can port anything you want to the original PR.

Yup.

@tatu-at-datastax tatu-at-datastax deleted the tatu/1647-race-condition-fix branch June 24, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants