Make test result uploads not break CI when fail #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBorczuk
requested review from
mpenick,
olim7t,
ivansenic,
tatu-at-datastax and
jeffreyscarpenter
as code owners
jeffreyscarpenter
approved these changes
May 19, 2022
tatu-at-datastax
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The final step (post-testing) of the CI is to do some codacy/jacoco upload step. Sometimes the remote is unavailable, as is the case with the internet...but we fail the entire hour-and-change long build when for all intents and purposes, the tests succeed.
I'm not sure to what degree we actually use Codacy/jacoco reports, but in any case, these intermittent failures should NOT block CI, and this PR should save us a ton of time.
Which issue(s) this PR fixes:
Checklist