-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes #2068: Enable gRPC reflection #1853
Conversation
@@ -77,6 +78,7 @@ public GrpcImpl( | |||
.intercept( | |||
new TaggingMetricCollectingServerInterceptor( | |||
metrics.getMeterRegistry(), grpcMetricsTagProvider)) | |||
.addService(ProtoReflectionService.newInstance()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Enabled by default.
This can be merged after a review. |
This is useful for gRPC tools that can utilize reflection information e.g. Postman.
e60dd1d
to
b699368
Compare
/gcbrun |
grpc/src/main/java/io/stargate/grpc/service/interceptors/NewConnectionInterceptor.java
Show resolved
Hide resolved
Nice simplification of tests @ivansenic! Looks good. |
/gcbrun |
/gcbrun |
What this PR does:
Enables gRPC reflection. This is useful for gRPC tools that can utilize reflection information
e.g. Postman.
Checklist