closes #2068: Enable gRPC reflection #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenick
commented
May 25, 2022
| @@ -77,6 +78,7 @@ public GrpcImpl( | |||
| .intercept( | |||
| new TaggingMetricCollectingServerInterceptor( | |||
| metrics.getMeterRegistry(), grpcMetricsTagProvider)) | |||
| .addService(ProtoReflectionService.newInstance()) | |||
There was a problem hiding this comment.
Maybe make this optional?
There was a problem hiding this comment.
Done. Enabled by default.
|
This can be merged after a review. |
This is useful for gRPC tools that can utilize reflection information e.g. Postman.
ivansenic
force-pushed
the
mpenick/grpc-reflection
branch
from
e60dd1d
to
b699368
Compare
|
/gcbrun |
ivansenic
changed the title
ivansenic
reviewed
Sep 27, 2022
grpc/src/main/java/io/stargate/grpc/service/interceptors/NewConnectionInterceptor.java
Show resolved
Hide resolved
|
Nice simplification of tests @ivansenic! Looks good. |
tatu-at-datastax
approved these changes
Sep 27, 2022
|
/gcbrun |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Enables gRPC reflection. This is useful for gRPC tools that can utilize reflection information
e.g. Postman.
Checklist