closes #2455: coordinator folder refactoring final #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivansenic
commented
Mar 7, 2023
tatu-at-datastax
approved these changes
Mar 7, 2023
| @@ -52,39 +52,40 @@ Each API Service contains its own integration test suite that tests it against t | |||
| ### Coordinator Node | |||
There was a problem hiding this comment.
Something is wrong right above this. These lines don't belong:
**Warning:** Support for Cassandra 3.11 is considered deprecated and will be removed in the Stargate v3 release: [details](https://github.com/stargate/stargate/discussions/2242).
**Warning:** Support for Cassandra 3.11 is considered deprecated and will be removed in the Stargate v3 release: [details](https://github.com/stargate/stargate/discussions/2242).
- **Authentication Services**: Responsible for authentication to Stargate
There was a problem hiding this comment.
I did not add this. Will remove.
| @@ -14,5 +14,5 @@ | |||
| # KIND, either express or implied. See the License for the | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/apache-maven-3.8.4-bin.zip | |||
| wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar | |||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.0/apache-maven-3.9.0-bin.zip | |||
There was a problem hiding this comment.
Just wondering if these changes are really in the scope for this PR?
There was a problem hiding this comment.
Yea when I was trying to make a shared maven wrapper I did update the version.. So I kept it.. The work was already invested, not sure why would we not have it now?
jeffreyscarpenter
approved these changes
Mar 8, 2023
ivansenic
force-pushed
the
ise-2455-coordinator-folder-final
branch
from
2428cf7
to
583e6ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
I tried different things, but for now I would like to close the #2455 with the more or less same structure as now. So no shared pom, the projects can be opened independently or added to a single workspace in IDE.
What's done:
I noticed some issues, will try to comment on some, but there are others that we should create tickets for:
Which issue(s) this PR fixes:
Fixes #2455