Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support developer mode #32

Merged
merged 4 commits into from Sep 11, 2020
Merged

Support developer mode #32

merged 4 commits into from Sep 11, 2020

Conversation

jorgebay
Copy link
Contributor

When developer mode is set, the stargate node joins the ring and defaults the seed list to itself.

When developer mode is set, the stargate node joins the ring and defaults the seed list to itself
@jorgebay
Copy link
Contributor Author

You can use the following command to start in developer mode:

./starctl --cluster-name stargate --cluster-version 3.11 --listen 127.0.0.1 --simple-snitch --developer-mode

@jorgebay
Copy link
Contributor Author

I've simplified it a little further by setting simple snitch in developer mode, the new command w/ the required parameters is:

./starctl --cluster-name stargate --cluster-version 3.11 --listen 127.0.0.1 --developer-mode

@jorgebay
Copy link
Contributor Author

I've rolled in a change here to make binding to listen address opt-in.

Comment on lines +127 to +133
@Option(name = {"--developer-mode"}, description = "Defines whether the stargate node should also behave as a " +
"regular node, joining the ring with tokens assigned in order to facilitate getting started quickly and not " +
"requiring additional nodes or existing cluster")
boolean developerMode = false;

@Order(value = 15)
@Option(name = {"--bind-to-listen-address"}, description = "When set, it binds web services to listen address only")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these to starctl as well since we also support env vars.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I've added them.

Copy link
Contributor

@dougwettlaufer dougwettlaufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs the script update.

@dougwettlaufer dougwettlaufer merged commit e5950c7 into master Sep 11, 2020
@dougwettlaufer dougwettlaufer deleted the developer-mode branch September 11, 2020 18:20
@mpenick
Copy link
Contributor

mpenick commented Sep 14, 2020

@jorgebay These changes need to also be made to the other persistence backends: https://github.com/stargate/persistence-extensions

@jorgebay
Copy link
Contributor Author

There was a small discussion on the private repo, tldr: only support it in the built-in C* 3.11 for now.

I think it it's valuable for users to have a developer mode that doesn't require an additional cluster. Having 3.11 support for dev mode is good enough for me, but if you think that we need it for dse and C* 4.0 we should file a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants