Do not pull schema from non-token ring members #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In retrospect, it is a bug to pull schema from non-ring members and schema should only be pulled from the storage nodes. Pulling schema from ring members is handled in the`StorageService#onChange()` method.
mpenick
requested review from
dimas-b,
dougwettlaufer,
EricBorczuk,
olim7t,
pcmanus and
tomekl007
as code owners
tomekl007
reviewed
Jan 21, 2021
|
|
||
| // This fix schedules a schema pull for the non-member node and is required because | ||
| // `StorageService.onChange()` doesn't do this for non-member nodes. | ||
| MigrationManager.instance.scheduleSchemaPull(endpoint, epState); |
There was a problem hiding this comment.
is it feasible to write a test (probably integration test) that checks that the schema from the non-member node is not pulled?
There was a problem hiding this comment.
I really don't think so, but I did prove it manually and by analyzing the C*/DSE code.
dougwettlaufer
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In retrospect, it is a bug to pull schema from non-ring members and schema should only be pulled from the storage nodes. Pulling schema from ring members is handled in the
StorageService#onChange()method.