Fix #536 - Replace String padding by library call #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eribeiro
requested review from
dimas-b,
dougwettlaufer,
EricBorczuk,
mpenick,
olim7t,
pcmanus and
tomekl007
as code owners
|
/gcbrun |
dougwettlaufer
approved these changes
Feb 19, 2021
dimas-b
reviewed
Feb 19, 2021
| assertThat(result).isEqualTo("000000"); | ||
|
|
||
| result = (String) leftPadTo6.invoke(service, "00"); | ||
| assertThat(result).isEqualTo("000000"); |
There was a problem hiding this comment.
I think it's worth keeping this test. Even though we use a lib to do the work, the fact that 0 is used for padding is something affected by our code... but of course we do not need as many test cases now.
dimas-b
approved these changes
Feb 22, 2021
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace String padding by library call and minor refactoring.