Quick graphql readme cleanup #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwettlaufer
requested review from
dimas-b,
EricBorczuk,
ivansenic,
mpenick,
olim7t and
tomekl007
as code owners
olim7t
approved these changes
Mar 23, 2021
@olim7t I had the same thought as well. I initially started this PR with the intent of removing the majority of this but kept it since this seems to go more in depth. This readme seems to be more of a technical "what" and the docs are more of a "how". @polandll what are your thoughts? |
Co-authored-by: Olivier Michallat <olim7t@users.noreply.github.com>
Co-authored-by: Olivier Michallat <olim7t@users.noreply.github.com>
|
I can go through this and incorporate anything that the docs are missing, and then this doc can be removed. Seems maybe the best way to do it. That way, you all don't have to keep maintaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.