Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on some locales #40

Closed
L3337 opened this issue May 13, 2023 · 2 comments
Closed

Crashes on some locales #40

L3337 opened this issue May 13, 2023 · 2 comments

Comments

@L3337
Copy link
Member

L3337 commented May 13, 2023

At the present, there are some fairly deep issues that cause crashes on locales with large alphabets that use unicode, such as Korean and Japanese, probably others.

The solution is going to be to devise a cross-platform strategy to use utf-8 for all files and file paths in the Python code (the easy part), and properly handle these paths under the hood in the C code in a way that works on Windows and UNIX (the hard part).

Potential strategies to solve this are being evaluated right now, for now the only way to ensure that Stargate works is to use en_US locale.

@L3337
Copy link
Member Author

L3337 commented May 14, 2023

Managed to get this sorted out much faster than anticipated, because it is a massive change that touches pretty much everything. I have code in the engine-unicode-support branch that works on every Linux and Windows locale that I have tested it on, but it needs some intense end-to-end regression testing on multiple locales, which will probably take all week.

Still untested is MacOS, which I am hoping has proper support for utf8 as Linux does. Since I cannot create 10 VMs of different MacOS locales to properly test like I can for Windows and Linux. Figuring out proper worldwide MacOS support will likely come after the next release.

@L3337
Copy link
Member Author

L3337 commented May 15, 2023

I'm going to say that this bug is fixed for now. Seems to be in good shape on every platform I have tested on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant