Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save last selected account #34

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/screens/add-transaction-screen/add-transaction-next-screen.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
import React, { useState, useEffect } from "react";
import { ScrollView, StyleSheet, Text, View, Platform } from "react-native";
import {
ScrollView,
StyleSheet,
Text,
View,
Platform,
AsyncStorage,
} from "react-native";
import { Portal, Toast, List, DatePicker } from "@ant-design/react-native";
import { connect } from "react-redux";
import { NavigationBar } from "@/common/navigation-bar";
Expand Down Expand Up @@ -120,7 +127,15 @@ export const AddTransactionNextScreen = connect(
Portal.remove(loadingKey);

if (!error) {
Toast.success(i18n.t("saveSuccess"), 2, () => {
Toast.success(i18n.t("saveSuccess"), 2, async () => {
try {
await AsyncStorage.setItem("@LastSelectedAssets:key", assets);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about move to mmkv

await AsyncStorage.setItem("@LastSelectedExpenses:key", expenses);
} catch (aserror) {
console.error(
`failed to set last selected assets or expenses value: ${aserror}`
);
}
props.navigation.pop();
if (onRefresh) {
onRefresh();
Expand Down
28 changes: 28 additions & 0 deletions src/screens/add-transaction-screen/quick-add-accounts-selector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
StyleSheet,
Text,
View,
AsyncStorage,
} from "react-native";
import { connect } from "react-redux";
import { List } from "@ant-design/react-native";
Expand Down Expand Up @@ -80,13 +81,40 @@ export const QuickAddAccountsSelector = connect(
loading,
refetch,
} = useLedgerMeta(userId);

const [selectedAssets, setSelectedAssets] = useState(
assetsOptionTabs.length > 0 ? assetsOptionTabs[0].options[0] : ""
);
const [selectedExpenses, setSelectedExpenses] = useState(
expensesOptionTabs.length > 0 ? expensesOptionTabs[0].options[0] : ""
);

React.useEffect(() => {
async function init() {
try {
const lastSelectedAssets = await AsyncStorage.getItem(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we turn these getter and setter to react hooks? https://usehooks.com/useLocalStorage/

"@LastSelectedAssets:key"
);
if (lastSelectedAssets !== null) {
setSelectedAssets(lastSelectedAssets);
}
const lastSelectedExpenses = await AsyncStorage.getItem(
"@LastSelectedExpenses:key"
);
if (lastSelectedExpenses !== null) {
setSelectedExpenses(lastSelectedExpenses);
}
} catch (aserror) {
console.error(
`failed to get get last selected assets or expenses value: ${aserror}`
);
}
}
if (!loading) {
init();
}
}, [loading]);

useEffect(() => {
const currency = currencies.length > 0 ? currencies[0] : "";
if (onChange) {
Expand Down
2 changes: 1 addition & 1 deletion src/screens/mine-screen/about.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ import { useUpdateReportSubscribeToRemote } from "@/screens/mine-screen/hooks/us
import { useFeatureFlags } from "@/common/feature-flags/use-feature-flags";
import { AccountHeader } from "@/screens/mine-screen/account-header";
import { InviteSection } from "@/screens/referral-screen/components/invite-section";
import { ReportStatus } from "../../../__generated__/globalTypes";
import { useIsFocused } from "@react-navigation/native";
import { ReportStatus } from "../../../__generated__/globalTypes";

const { Item } = List;
const { Brief } = Item;
Expand Down