Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After a hot reload, RenderObject does not relayout #7

Closed
stargazing-dino opened this issue Jun 18, 2021 · 1 comment
Closed

After a hot reload, RenderObject does not relayout #7

stargazing-dino opened this issue Jun 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@stargazing-dino
Copy link
Owner

This means if we change the axis, no new constraints are processed.

This likely will be fixed with making each property a setter and getter and making the correct thing dirty. Either paint or layout.

@stargazing-dino stargazing-dino added the enhancement New feature or request label Jun 18, 2021
@stargazing-dino
Copy link
Owner Author

c89823d

turns out I wasn't calling the correct setters in my _RenderTooltipOverlay

was doing

EdgeInsets get margin => _margin;
  EdgeInsets _margin;
  set margin(EdgeInsets value) {
    if (_margin == value) return;
    _margin = margin;
    markNeedsLayout();
  }

instead of

EdgeInsets get margin => _margin;
  EdgeInsets _margin;
  set margin(EdgeInsets value) {
    if (_margin == value) return;
    _margin = value;
    markNeedsLayout();
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant