Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding status notifier #37

Closed
wants to merge 1 commit into from
Closed

adding status notifier #37

wants to merge 1 commit into from

Conversation

zmhbh
Copy link

@zmhbh zmhbh commented Oct 7, 2021

Hello, thanks for creating this lib, it's so powerful. When I use this lib, I realized the "controller.isShowing" doesn't work as expected. After some investigation, I found the controller.value would be changed multiple time for each user action. So I exposed this tooltip status. I also updated the example for your reference. Feel free to update these changes if there is better implementation. Thanks~

@zmhbh
Copy link
Author

zmhbh commented Oct 7, 2021

@Nolence Please take a look~

@stargazing-dino
Copy link
Owner

Hello ! Thank you for the PR

I'm curious to know more about the issue. The controller was a quick feature I implemented and I was scared it might not catch all use cases or be broken in some places. Before we get to this PR, do you mind creating an issue with the original problem and what you expect to happen? A video, call stack or a bunch of print logs would be helpful. I plan to work on this lib a lot soon in preparation for #20 so I wouldn't mind working on something like this soon

@zmhbh
Copy link
Author

zmhbh commented Oct 8, 2021

Hello ! Thank you for the PR

I'm curious to know more about the issue. The controller was a quick feature I implemented and I was scared it might not catch all use cases or be broken in some places. Before we get to this PR, do you mind creating an issue with the original problem and what you expect to happen? A video, call stack or a bunch of print logs would be helpful. I plan to work on this lib a lot soon in preparation for #20 so I wouldn't mind working on something like this soon

Sure.

@stargazing-dino
Copy link
Owner

Thank you for this PR and work ! Closing as fixed in 0.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants