Avoid tooltip area gesture detection for manual trigger mode #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay on this. Holidays had me busy. This is a great change. Thanks for the PR ! |
stargazing-dino
added a commit
that referenced
this pull request
Jan 3, 2022
Avoid tooltip area gesture detection for manual trigger mode
|
@Nolence do you have any idea when you'll push a new release to pub.dev? |
|
Apologies ! I thought I had published but looking through console history I think I did a dry run instead :\ Anyways, this change is now on pub with version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a tooltip only in the
manualtrigger mode, so we show it only by usingcontroller.showTooltip(), but in some situations the tooltip is unintentionally shown by a tap gesture.Let's avoid wrapping it in the
GestureDetector/MouseRegionwhen only themanualtrigger mode is used.