Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: work around addressable settings delayed initialization #87

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

starikcetin
Copy link
Owner

@starikcetin starikcetin commented Dec 24, 2023

Closes #65
Supersedes #66

Turns out Addressables provides a global event listening mechanism which doesn't require us to reach for the default settings file. This solution also doesn't require any delays which might cause unpredictable behaviour in batchmode builds.


TODO:

  • Changelog

@starikcetin starikcetin self-assigned this Dec 24, 2023
@starikcetin starikcetin added the bug Something isn't working label Dec 24, 2023
@starikcetin
Copy link
Owner Author

@Ale1 Can you check this one?

@starikcetin
Copy link
Owner Author

I verified that it is working as intended.

@starikcetin
Copy link
Owner Author

Included in 3.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening project with addressable + sceneReference package for first time can lead to init race condition
1 participant