Skip to content

Commit

Permalink
Changed the default value for includeInactive to be true, because of …
Browse files Browse the repository at this point in the history
…reasons discussed in issue modesttree#275
  • Loading branch information
svermeulen committed Jun 5, 2018
1 parent 12b14b3 commit 82e99cb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public FactorySubContainerBinder<TContract> FromSubContainerResolve(object subId
#if !NOT_UNITY3D

public ConditionCopyNonLazyBinder FromComponentInHierarchy(
bool includeInactive = false)
bool includeInactive = true)
{
BindingUtil.AssertIsInterfaceOrComponent(ContractType);

Expand Down
14 changes: 7 additions & 7 deletions Source/Binding/Binders/FromBinders/FromBinderGeneric.cs
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public ScopeConditionCopyNonLazyBinder FromInstance(TContract instance)

#if !NOT_UNITY3D

public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInChildren(bool includeInactive = false)
public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInChildren(bool includeInactive = true)
{
BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);

Expand All @@ -104,13 +104,13 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInChildren(bool
}

public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInChildren(
Func<TContract, bool> predicate, bool includeInactive = false)
Func<TContract, bool> predicate, bool includeInactive = true)
{
return FromComponentsInChildren(false, predicate, includeInactive);
}

public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInChildren(
bool excludeSelf = false, Func<TContract, bool> predicate = null, bool includeInactive = false)
bool excludeSelf = false, Func<TContract, bool> predicate = null, bool includeInactive = true)
{
BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);

Expand All @@ -137,7 +137,7 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInChildren(bool
}

public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInParents(
bool excludeSelf = false, bool includeInactive = false)
bool excludeSelf = false, bool includeInactive = true)
{
BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);

Expand All @@ -164,7 +164,7 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInChildren(bool
}

public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInParents(
bool excludeSelf = false, bool includeInactive = false)
bool excludeSelf = false, bool includeInactive = true)
{
BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);

Expand Down Expand Up @@ -219,7 +219,7 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsSibling()
}

public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInHierarchy(
bool includeInactive = false)
bool includeInactive = true)
{
BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);

Expand All @@ -236,7 +236,7 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsSibling()
}

public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInHierarchy(
Func<TContract, bool> predicate = null, bool includeInactive = false)
Func<TContract, bool> predicate = null, bool includeInactive = true)
{
BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);

Expand Down

0 comments on commit 82e99cb

Please sign in to comment.