Cleaning filter data from strings and empty datasets before using it #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in comment on issue#13: starkit#13 (comment), this cleans those filters from filter_index that have empty filter dataset (dataframe).
|
These both commits fix all the problems (Garbage Strings + Empty dataframes) in parsing filters from current HDF file wsynphot is using. I've tested this by using notebook that allows user to make arbitrary selection of facility & instrument (by dropdowns). |
jaladh-singhal
changed the title
|
I think it's better if we have all of that in the ingesting method rather than on load. |
wkerzendorf
reviewed
Jun 4, 2019
| @@ -79,6 +90,20 @@ def list_filters(): | |||
|
|
|||
| return get_filter_index() | |||
|
|
|||
| #To check whether both passed strings are float or not | |||
There was a problem hiding this comment.
try it and if it raises ValueError just leave that ValueError through
There was a problem hiding this comment.
Actually its purpose is for cleaning the data. It returns boolean for each element in dataframe because we need a series to clean the data by boolean indexing.
It might appear confusing here, it will become clear in new PR I'm creating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves error in loading filters that were failing due to presence of garbage strings in data fetched from hdf file (i.e. part-1 in problems mentioned in issue#13). The data
filter dataframeis cleaned before it is used inload_filter()function.