Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ingest_from_svo notebook and filter data files #22

Closed
wants to merge 2 commits into from

Conversation

jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented Jun 4, 2019

  1. It fixes the problems in issue Error in loading certain filters #13 by adding the data cleaning script within the ingestion script (in notebook). Also it does some python3, etc. necessary changes.
  2. It has updated the filter data files by adding new files that were not present last time of commit (since SVO updates itself by adding new filters) and by renaming rest of files by adding .dat extension.

This adding of extension is necessary because earlier file names were in <instrument>.<filter> format, thus GitHub is identifying filter names such as J, C, G, etc. as extensions and showing wrong language status (Jasmin, C, GAP, etc. respectively) of the wsynphot. Thus we need to explicitly add .dat while defining filenames in the ingestion script.

@wkerzendorf
Copy link
Member

let's take all the SVO files out - they shouldn't have been added in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants