Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added starknet foundry snforge #219

Merged
merged 1 commit into from
Oct 17, 2023
Merged

added starknet foundry snforge #219

merged 1 commit into from
Oct 17, 2023

Conversation

Akinbola247
Copy link
Contributor

@omarespejel Here's a PR in reference to #201 issue. I've added detailed explanation on starknet foundry snforge. kindly review and let me know your thoughts.

@omarespejel omarespejel merged commit 952798b into starknet-edu:main Oct 17, 2023
@omarespejel
Copy link
Collaborator

Hey @Akinbola247! Thank you! It is looking good. I merged it and will make some edits internally today and come back with feedback or suggestions if needed. Wait for my feedback today, thanks! 🚀

@Akinbola247
Copy link
Contributor Author

Alright @omarespejel looking forward to it 💪🏼

@omarespejel
Copy link
Collaborator

omarespejel commented Oct 19, 2023

Hello @Akinbola247

Thank you for your PR. Your efforts have set us on a promising path! To ensure our content delivers maximum value to the readers, some enhancements are in order. Recognizing the effort involved wi, I'm prepared to increase the bounty to $250 should you wish to make these revisions. If not, please let me know.

I did some editions on your first PR so we can continue from there, check it here: https://book.starknet.io/ch02-11-foundry-forge.html

Here's a structured approach to the improvements:

  • Incorporate Basecamp Session: Begin by integrating insights from the recent Basecamp session into the book. This session is comprehensive and touches upon many aspects we want to cover. It is important to delve into the details of testing a smart contract. The Basecamp session deals with a lot of this but consider adding more details.

  • Filtering Insight: Elaborate on filtering, explaining its significance and application, as touched upon in the session. The same applies to the rest of the flags: exact and exit first.

  • Distinctiveness from Foundry Docs: Ensure our content distinguishes itself from the Foundry documentation. While the Foundry docs provide a base, our emphasis should be on real-world examples. For fundamental details, we can direct readers to the Foundry docs.

  • Additional Examples: Introduce a different testing example, perhaps from the starknet-js examples.

  • Use of Cheatcodes & Tests: Supplement the content with relevant cheatcodes like start_prank and consider integrating fuzz tests.

Your dedication is greatly appreciated, and these additions will undeniably elevate our content.

@Akinbola247
Copy link
Contributor Author

@omarespejel thanks for the feed back, I’ll get right on it!

@omarespejel
Copy link
Collaborator

Thank you @Akinbola247! We are completely on the right path. Let me know if you need feedback or anything. My telegram is espejelomar

@Akinbola247
Copy link
Contributor Author

Hi @omarespejel i've made the PR here #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants