New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: github allocation #19
base: main
Are you sure you want to change the base?
Conversation
b6145f3
to
4394747
Compare
What does it represent? Please explain a little more clearly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Good job bro |
is a fair solution to the problem! |
Nice one bro |
Any suggestion where the free tokens will be allocated? |
it's funny seeing community fixing the starknet airdrop issues. they could literally fetch the github ids instead of username and not causing any of those issues, since a user would be required to SSO with github to claim the reward. so amateur. something tells me this ain't gonna be merged anytime soon. |
alright actually they have at least blacklisted the squattered usernames. https://github.com/starknet-io/provisions-data/blob/main/github_squatted_usernames.csv I guess those whose usernames were changed post-snapshot are gonna be able to claim in some while. |
Nice work, my rename wasn't catched tho and there's a squatter :( |
Any update on this, I have also checked my username has been removed - I renamed my account but I'm not sure why it's now been removed from the list. |
Very appreciate that! I changed my user name, too. The former user name showed in /github/github-1.json, but has been squatted by a new register account. I believe that there are lots of people who have the same situation and are hoping Starknet official to resolve that problem. |
+1 - any update Starknet guys? Would be awesome to potentially re-run the airdrop criteria and update the merkle root with just the ID's instead of usernames. |
+1, My old github account username was removed in the first commit of this PR. Former username was in the |
Thanks for this banteg! My old github username (umphams) was literally squatted by someone else the day after the airdrop eligibility was announced. Has Starknet said they were going to do anything else? I saw your tweet saying that "they'd take care of the real devs." I guess the person who squatted my old username (the day after the airdrop eligibility was announced lol) was blacklisted right? I see my old username in the "squat" list. |
We have setup a Telegram for all users who have been squatted: https://t.me/+LiFfOhYqBb00NWVi |
Potentially scam link above, beware |
Not a scam link. I'm in there. 5 people are members. We made it to collaborate on the issue. You can join too. |
i'll put the info I addressed in that tg group over here. TABLE OF CONTENTS
PrefaceStarknet has launched an airdrop on 20th Feb 2023, providing a GitHub based eligibility for those who had contributed to Top 5000 GitHub Repos or Starknet-related repositories. Needless to say that this whole issue comes down to the fact that the snapshot was taken by usernames and not github IDs. We all understand that. Why are we importantOne could think – "Uh, it sucks, most of the devs claimed their airdrops and I am one of the few affected", but it is tottally wrong. A rookie-level estimation could tell us that there are 10150/0.32 = ~31719 total users eligible for GitHub allocation, and 1796/31719 comes down to 5.64% of total GitHub users being affected by the bugged snapshot, with an estimate of 55.2M*5.64% = 3.11M $STRK tokens being left for "potential future community allocation". That is by the way, the only official anouncement we have received regarding this issue. I believe such an anouncement to be not accurate, it doesn't state wether the "~1M" tokens saved from the squatted usernames that might have led to double-claim issue, neither that the issue is fixed and developers would be able to receive the airdrop. Why am I addressing all of thisFrom what it seems, Starknet Team doesn't want to take responsibility for what has happened. Of course – nobody lost any funds, it's all about free wavey, but people are certainly feeling left out, ignored, uncertainty wether this gets fixed or not. How we addressed the issue@BantG has spend his time opening a PR in provisions repository claiming to have fixed the github allocation list, at least for 1175 users. Unfortunately, it was never reviewed nor commented by Starknet team. How Starknet team addressed the issue
What do I expect from StarknetI expect an official statement regarding this issue to clearly tell people wether this gets fixed or not. How can we help StarknetThere are at least 1796 potential contributors who might invest their time helping fixing this issue, however the provisions website itself is clouse-sourced (at least I haven't found a repo). How to contribute to this issueI in no case want to produce any harm to the Starknet Ecosystem as a whole, so don't expect me to initiate any "raids/spams" on twitter nor discord. |
Commenting on this PR again, as we are still looking to collaborate with all devs that got squatted and find the solution together in the telegram chat above. |
@@ -505,7 +497,7 @@ | |||
"amount": "111.1" | |||
}, | |||
{ | |||
"identity": "evilebottnawi", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that these usernames, evilebottnawi
(id 23334705) and alexander-akait
(id 4567934), should have the same id
to reflect that they are the same user but with a changed username, but they do not have the same id. Both were created before 2018, suggesting evilebottnawi
isn't a squatter, though I could be mistaken.
I might be overlooking something, but it appears they didn't meet the first requirement of your method. @banteg, could you kindly clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ ag -B1 4567934
bq_gharchive/bq_2018.json
1412- "login": "evilebottnawi",
1413: "id": "4567934"
then go here https://api.github.com/user/4567934 to see the current name. the other account was created in 2016, so it's probably not a squatter, just an alt.
Hey @banteg, Omar from the Starknet Foundation here. While reviewing your updates, I have a couple of questions:
|
Hey @banteg, just a gentle reminder to check my previous messages when you have a moment. Thanks! |
@omarespejel it's explained in the first message, i have used https://www.gharchive.org/ dataset on bigquery. it indexes all public events on github. i ran this query for years 2018-2023, so i looked up by username, and haven't used emails. the limitation is it could've missed people who renamed their account earlier or had no public activity in this period. i also queried github api to look up ids, up-to-date names by id and deleted accounts. |
thanks @banteg for your efforts on this. happy to help where i can to make sure this issue gets resolved. |
this addresses the issue of people renaming accounts since the github snapshot was taken. it also removes deleted accounts from the allocation. it also addresses the squatting by excluding accounts with a recent creation date.
methodology
overall this reduces allocation by 701,544 and accounts by 1175.