Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet extensions supports edge browser #326

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

nlyrthiia
Copy link

@nlyrthiia nlyrthiia commented Nov 27, 2022

Description of the Changes

Wallet connection supports edge browser.

This is the value of Desktop Browser Market Share worldwide OCT2021-OCT2022 link:

  • Chrome 66.46%
  • Edge 10.85%
  • Safari 9.38%
  • Firefox 7.05%

It can be seen that the share of Edge is still good. The native plug-in of Edge already supports Metamask, and Edge is fully compatible with other Chrome plug-ins, and can be used normally during the development process.

origin:
image

change:

Not Installed:

Screencast.from.27-11-22.12.11.07.webm

Installed:

Screencast.from.27-11-22.12.15.13.webm

Checklist

  • Manually tests of the main Application flows are done and passed.
  • New unit / functional tests have been added (whenever applicable).
  • Docs have been updated (whenever relevant).
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

@dan-ziv
Copy link
Collaborator

dan-ziv commented Nov 27, 2022

Hey @nlyrthiia - nice catch!
Since Edge is chromium-based, all Chrome-supported extensions should work either on Edge, that's great.

We are changing the wallet abstraction handlers from classes to hooks, so I don't want to add this support to code that will be removed in the next version.

I suggest waiting with this PR to v1.11.0 and then adding it again with the new implementation. WDYT?

@nlyrthiia
Copy link
Author

nlyrthiia commented Nov 29, 2022

@dan-ziv Ok, I think we can wait until after v1.11.0 to implement edge support.

And I found some problems in the process of using Starkgate. Now I am also participating in the ecological construction related to Starknet. I am looking for something I can do.

If I have the opportunity, I hope to participate in the latest Starkgate-frontend project. Get To the latest progress, so that I can be more precise about some PRs of Starkgate-frontend and avoid doing some work that will conflict with your existing progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants