refactor: create wallet namespace #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivpavici
reviewed
Mar 29, 2024
src/index.ts
Outdated
| @@ -43,6 +43,7 @@ export * from './utils/calldata/enum'; | |||
| export * from './utils/contract'; | |||
| export * from './utils/events'; | |||
| export * from './utils/transactionReceipt'; | |||
| export * as wallet from './wallet/wallet'; | |||
There was a problem hiding this comment.
I know there was a discussion about this on Discord, but if we have a better idea not to have wallet/wallet ? I know naming is the hardest thing in development and I'm nitpicking xD
cc @tabaktoni
There was a problem hiding this comment.
Do you prefer a file called walletAPI.ts ?
There was a problem hiding this comment.
One possibility is to use export * as wallet from './wallet' in src/wallet/index.ts in place of export * from './connect' instead of removing it (could even keep the connect file name).
There was a problem hiding this comment.
I went back to connect.ts, keeping export * as wallet.
penovicp
pushed a commit
that referenced
this pull request
Apr 3, 2024
* refactor: create wallet namespace * fix: change name to connect.ts --------- Co-authored-by: Toni Tabak <tabaktoni@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Wallet API functions have to be imported one by one
from "starknet"Create a
walletnamespace is solving this problem, and will group all methods related to this subject.Usage related changes
Development related changes
connect.tsrenamedwallet.tsChecklist: