Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added JS Docs Examples for typedDatadocs #1127

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

fishonamos
Copy link

@fishonamos fishonamos commented May 15, 2024

Checklist:

src/utils/typedData.ts Outdated Show resolved Hide resolved
@ivpavici ivpavici added the Type: documentation Improvements or additions to documentation label May 17, 2024
@fishonamos
Copy link
Author

Kindly review @ivpavici

@fishonamos fishonamos changed the title Docs: Added JS Docs Examples for typedDatadocs docs: Added JS Docs Examples for typedDatadocs May 19, 2024
@ivpavici ivpavici requested a review from dsperac May 20, 2024 12:27
src/utils/typedData.ts Outdated Show resolved Hide resolved
src/utils/typedData.ts Outdated Show resolved Hide resolved
src/utils/typedData.ts Outdated Show resolved Hide resolved
src/utils/typedData.ts Outdated Show resolved Hide resolved
src/utils/typedData.ts Outdated Show resolved Hide resolved
src/utils/typedData.ts Outdated Show resolved Hide resolved
@fishonamos
Copy link
Author

kindly review @ivpavici

@fishonamos fishonamos requested a review from ivpavici May 22, 2024 06:58
@ivpavici ivpavici requested a review from PhilippeR26 May 22, 2024 07:56
@ivpavici ivpavici requested a review from penovicp June 5, 2024 06:35
@fishonamos fishonamos requested a review from ivpavici June 10, 2024 16:58
* ```typescript
* const result1;
* const merkleType = {
* name: 'MerkleTree',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fishonamos we tested your examples and they are wrong... we cannot merge chatGPT generated comments without properly testing

@tabaktoni
Copy link
Collaborator

@dsperac refactor and close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants